inspector: Simplify populating the tree

No need to loop toplevels in two places.

diff --git a/gtk/inspector/inspect-button.c b/gtk/inspector/inspect-button.c
index 1c3135f54dfab15389e1e0e19ccb75779c046c45..b30b3637febff2e1659d90efc12f94835154555a 100644 (file)
--- a/gtk/inspector/inspect-button.c
+++ b/gtk/inspector/inspect-button.c
@@ -212,9 +212,6 @@ select_widget (GtkInspectorWindow *iw,
 
   gtk_notebook_set_current_page (GTK_NOTEBOOK (iw->top_notebook), 0);
 
-  gtk_inspector_widget_tree_scan (GTK_INSPECTOR_WIDGET_TREE (iw->widget_tree),
-                                  gtk_widget_get_toplevel (widget));
-
   gtk_inspector_widget_tree_select_object (GTK_INSPECTOR_WIDGET_TREE (iw->widget_tree),
                                            G_OBJECT (widget));
 }

diff --git a/gtk/inspector/widget-tree.c b/gtk/inspector/widget-tree.c
index 8fd61308661fd89898c90f58b2dcb7ac354ec17b..507513fc42b58869f032f97fa8d6d09fbcb13d25 100644 (file)
--- a/gtk/inspector/widget-tree.c
+++ b/gtk/inspector/widget-tree.c
@@ -497,6 +497,9 @@ gtk_inspector_widget_tree_scan (GtkInspectorWidgetTree *wt,
   if (g_application_get_default ())
     gtk_inspector_widget_tree_append_object (wt, G_OBJECT (g_application_get_default ()), NULL, NULL);
 
+  if (window)
+    gtk_inspector_widget_tree_append_object (wt, G_OBJECT (window), NULL, NULL);
+
   inspector_win = gtk_widget_get_toplevel (GTK_WIDGET (wt));
   toplevels = gtk_window_list_toplevels ();
   for (l = toplevels; l; l = l->next)
@@ -509,8 +512,6 @@ gtk_inspector_widget_tree_scan (GtkInspectorWidgetTree *wt,
     }
   g_list_free (toplevels);
 
-  gtk_inspector_widget_tree_append_object (wt, G_OBJECT (window), NULL, NULL);
-
   gtk_tree_view_columns_autosize (GTK_TREE_VIEW (wt));
 }
 

diff --git a/gtk/inspector/window.c b/gtk/inspector/window.c
index 9957128b09581083dc55ded0b1228c5532e0af5a..3e3750dbceff6a9598139e51b703701df4d0116e 100644 (file)
--- a/gtk/inspector/window.c
+++ b/gtk/inspector/window.c
@@ -152,36 +152,14 @@ gtk_inspector_window_init (GtkInspectorWindow *iw)
     }
 }
 
-static void
-gtk_inspector_window_select_initially (GtkInspectorWindow *iw)
-{
-  GList *toplevels, *l;
-  GtkWidget *widget;
-
-  toplevels = gtk_window_list_toplevels ();
-  widget = NULL;
-  for (l = toplevels; l; l = l->next)
-    {
-      if (gtk_widget_get_mapped (GTK_WIDGET (l->data)) &&
-          GTK_IS_WINDOW (l->data) &&
-          !GTK_INSPECTOR_IS_WINDOW (l->data))
-        {
-          widget = l->data;
-          break;
-        }
-    }
-  g_list_free (toplevels);
-
-  if (widget)
-    gtk_inspector_widget_tree_scan (GTK_INSPECTOR_WIDGET_TREE (iw->widget_tree), widget);
-}
-
 static void
 gtk_inspector_window_constructed (GObject *object)
 {
-  gtk_inspector_window_select_initially (GTK_INSPECTOR_WINDOW (object));
+  GtkInspectorWindow *iw = GTK_INSPECTOR_WINDOW (object);
 
   G_OBJECT_CLASS (gtk_inspector_window_parent_class)->constructed (object);
+
+  gtk_inspector_widget_tree_scan (GTK_INSPECTOR_WIDGET_TREE (iw->widget_tree), NULL);
 }
 
 static void